[Bug 497640] Review Request: rubygem-RedCloth - Textile parser for Ruby.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497640





--- Comment #3 from Dan Horák <dan at danny.cz>  2009-04-30 12:05:43 EDT ---
> > - is it possible to run the included testsuite during the build (using the
> > %check section)?  
> 
> Running them will require someone to submit echoe
> <http://www.workingwithrails.com/rubygem/4726-echoe> as a package for Fedora.
> If somebody does that, I'll add running the tests to the spec.

OK

I have found another issues
- because there is a library written in C, the %build and %install sections
need to be handled differently -
https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Gem_with_extension_libraries_written_in_C
and I have seen some inspiration in rubygem-gettext
(http://cvs.fedoraproject.org/viewvc/rpms/rubygem-gettext/devel/rubygem-gettext.spec?revision=1.6&view=markup)

- rpmbuild complains that COPYING, CHANGELOG and README are listed twice,
probably they don't need to be explicitly specified with %doc

- and rpmlint complains about "summary ended with dot"

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.