[Bug 505356] Review Request: php-PHPMailer - PHP email transport class with a lot of features

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505356





--- Comment #9 from Remi Collet <fedora at famillecollet.com>  2009-08-01 03:16:29 EDT ---
@Gianluca can you try mantis with this package ? (glpi works fine with it)

@Patrick

First, sorry for the long delay..

> "Provide: php-runtime"

I really think than requiring php-common is enough for most libraires. This
package will be required by web apps (mantis, glpi, ...) which will requires
more stuff (apache, ...) if needed.

Requiring too much things is more an issue than not requiring such "trivial"
and optional package. And a lot of users want to use lighthttp rather than
apache.

I think description can be improved, for example with the upstream one
------
Full Featured Email Transfer Class for PHP. PHPMailer features:

    * Supports emails digitally signed with S/MIME encryption!
    * Supports emails with multiple TOs, CCs, BCCs and REPLY-TOs
    * Works on any platform.
    * Supports Text & HTML emails.
    * Embedded image support.
    * Multipart/alternative emails for mail clients that do not read HTML
email.
    * Flexible debugging.
    * Custom mail headers.
    * Redundant SMTP servers.
    * Support for 8bit, base64, binary, and quoted-printable encoding.
    * Word wrap.
    * Multiple fs, string, and binary attachments (those from database, string,
etc).
    * SMTP authentication.
    * Tested on multiple SMTP servers: Sendmail, qmail, Postfix, Gmail, Imail,
Exchange, etc.
    * Good documentation, many examples included in download.
    * It's swift, small, and simple.
------


REVIEW:
+ rpmlint is silent
php-PHPMailer.src: I: checking
php-PHPMailer.noarch: I: checking
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
+ package name ok
+ spec file name ok
+ package must meet the  Packaging Guidelines
+ Fedora approved license (LGPLv2+)
+ match the actual license
+ license included
+ spec file written in American English and legible (well don't think #---- are
usefull)
+ sources match the upstream 
2f7296bb63e863c5528c2d591e38f4e5  PHPMailer_v5.0.2.tar.gz
+ rpmbuild ok (F11.x86_64)
+ mock ok (F11.i386)
+ BuildRequires ok
- Requires (see above)
php >= 5.0.0
+ locales handled properly
+ no .so
+ own all directories that it creates
+ %defattr ok
+ %clean ok
+ %install start with rm -rf...
+ consistently use macro
+ contain code
+ no large documentation and not affect the runtime of the application
+ no gui
+ not own files or directories already owned by other packages
+ valid UTF-8
+ install and works finr (tested with glpi)

Should fix URL and description
Must fix php-mbstring dependency

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.