[Bug 514699] Review Request: jemmy - Java UI testing library

bugzilla at redhat.com bugzilla at redhat.com
Sat Aug 1 13:58:02 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=514699





--- Comment #5 from Guido Grazioli <guido.grazioli at gmail.com>  2009-08-01 09:58:01 EDT ---
Hello Victor,

* your specfile still has a %define; it would also be nice to move all other
%global to file start.

--

* In the procedure to build the source tarball, use export instead of checkout;

that way md5sum of the tarball matches against the file included in the srpms

--

* question: is there a particular reason you need ant >= 1.6.5, or can the
version be omitted?

cheers,
Guido

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list