[Bug 478372] Review request: Mathgl - Scientific plotting library.

Sun Aug 2 09:08:42 UTC 2009

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478372

--- Comment #20 from D Haley <mycae at yahoo.com>  2009-08-02 05:08:37 EDT ---
SPEC URL: http://dhd.selfip.com/427e/mathgl-1.9-3.spec
SRPM URL: http://dhd.selfip.com/427e/mathgl-1.9-3.fc10.src.rpm

Koji:
F10: Unable to run, dep errors from blocking bug
(http://koji.fedoraproject.org/koji/getfile?taskID=1573375&name=root.log)
F11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1573383

$cat files
Wrote: /home/makerpm/rpmbuild/SRPMS/mathgl-1.9-3.fc10.src.rpm
Wrote: /home/makerpm/rpmbuild/RPMS/i386/mathgl-1.9-3.fc10.i386.rpm
Wrote: /home/makerpm/rpmbuild/RPMS/i386/mathgl-devel-1.9-3.fc10.i386.rpm
Wrote: /home/makerpm/rpmbuild/RPMS/noarch/mathgl-doc-1.9-3.fc10.noarch.rpm
Wrote: /home/makerpm/rpmbuild/RPMS/i386/mathgl-debuginfo-1.9-3.fc10.i386.rpm

$ rpmlint `cat files | sed 's/Wrote: //' | tr '\n' '\ '`
mathgl.i386: W: shared-lib-calls-exit /usr/lib/libmgl-glut.so.5.0.0
exit at GLIBC_2.0
mathgl-devel.i386: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 2 warnings.

> * you're running autoreconf, so --disable-rpath to configure should work.
Didn't work, complains its an unknown option. However the libtool hack works
after an autoreconf. So this is Done.

> Usually we don't fix SMP make (at least when it requires regenerating
> autotools). Just send the patches upstream, drop Patch1 and its BRs and comment
> the %{?_smp_mflags} part with a note that it doesn't work in 1.9.

Not Done. I think we should keep it, especially seeing as we are 'reconfing
anyway. I will notify upstream however. Packages with functional SMP builds are
a lot easier to maintain, even with an autoreconf.

>Drop the definition of octtype as you're not using it, and change the %define's
into %global's.
>http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define
Fixed

>and run the following commands to regenerate the octave package database:
Fixed.

> drop the octave site stuff
Not done, as that breaks the oct file finding. This needs to work without user
intervention. So you still need something to help octave find mathgl.oct, even
with the pkg('rebuild').  

A dirty test indicates:
*pkg('rebuild') only searches the search paths of octave (this is in the manual
as well), 
*The rebuild is not persistent at finding the oct file between sessions if path
changes:

So either a symlink or the plugin proper must be in one of these, or we must
modify this permanently  

After rpm installation (w/o symlink):
--
[makerpm at spiderbox mathgl-1.9]$ sudo octave -q
octave:1> mathgl
error: `mathgl' undefined near line 1 column 1
octave:1>
addpath('/usr/libexec/octave/plugins/mathgl/i386-redhat-linux-gnu-api-v32/')
octave:2> pkg('rebuild')
octave:3> mathgl
octave:4> quit
[makerpm at spiderbox mathgl-1.9]$ sudo octave -q
octave:1> mathgl
error: `mathgl' undefined near line 1 column 1
octave:1> 
--

By default:
---
octave:1> path

Octave's search path contains the following directories:

.
/usr/libexec/octave/3.0.3/site/oct/i386-redhat-linux-gnu
/usr/libexec/octave/site/oct/api-v32/i386-redhat-linux-gnu
/usr/libexec/octave/site/oct/i386-redhat-linux-gnu
/usr/share/octave/3.0.3/site/m

Octave's search path contains the following directories:

.
/usr/libexec/octave/3.0.3/site/oct/i386-redhat-linux-gnu
/usr/libexec/octave/site/oct/api-v32/i386-redhat-linux-gnu
/usr/libexec/octave/site/oct/i386-redhat-linux-gnu
/usr/share/octave/3.0.3/site/m
/usr/share/octave/site/api-v32/m
/usr/share/octave/site/m
/usr/share/octave/site/m/startup
/usr/libexec/octave/3.0.3/oct/i386-redhat-linux-gnu
/usr/share/octave/3.0.3/m
/usr/share/octave/3.0.3/m/plot
/usr/share/octave/3.0.3/m/special-matrix
/usr/share/octave/3.0.3/m/finance
/usr/share/octave/3.0.3/m/optimization
/usr/share/octave/3.0.3/m/quaternion
/usr/share/octave/3.0.3/m/testfun
/usr/share/octave/3.0.3/m/path
/usr/share/octave/3.0.3/m/linear-algebra
/usr/share/octave/3.0.3/m/statistics
/usr/share/octave/3.0.3/m/statistics/models
/usr/share/octave/3.0.3/m/statistics/distributions
/usr/share/octave/3.0.3/m/statistics/tests
/usr/share/octave/3.0.3/m/statistics/base
/usr/share/octave/3.0.3/m/time
/usr/share/octave/3.0.3/m/elfun
/usr/share/octave/3.0.3/m/deprecated
/usr/share/octave/3.0.3/m/control
/usr/share/octave/3.0.3/m/control/hinf
/usr/share/octave/3.0.3/m/control/obsolete
/usr/share/octave/3.0.3/m/control/util
/usr/share/octave/3.0.3/m/control/base
/usr/share/octave/3.0.3/m/control/system
/usr/share/octave/3.0.3/m/pkg
/usr/share/octave/3.0.3/m/audio
/usr/share/octave/3.0.3/m/geometry
/usr/share/octave/3.0.3/m/set
/usr/share/octave/3.0.3/m/sparse
/usr/share/octave/3.0.3/m/image
/usr/share/octave/3.0.3/m/signal
/usr/share/octave/3.0.3/m/polynomial
/usr/share/octave/3.0.3/m/startup
/usr/share/octave/3.0.3/m/miscellaneous
/usr/share/octave/3.0.3/m/general
/usr/share/octave/3.0.3/m/io
/usr/share/octave/3.0.3/m/specfun
/usr/share/octave/3.0.3/m/strings
---

>Remove the documentation 'make install' installs in %{_docdir}/%{name} with
>rm -rf %{_docdir}/%{name}
>instead just list the necessary files in the %doc of the -doc subpackage
Done.

>Put the info files in the main package. 
Fixed

> You need to regenerate the info database as well:
> https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Texinfo  
Fixed

>You might not want to remove the zero-length files as if some of them are
>missing the program might not work. Best to ask upstream to remove the empty
>files from the distribution.
There are exactly 2 files that are zero-length, one is the INDEX file for
octave (which is an optional file), and the second is the all.png file, which
is being used as a faux target in the makefile, as far as i can tell. I have
simply rm'd them instead of using the catchall, so this is Done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.