[Bug 507480] Review Request: moblin-icon-theme - Moblin icon theme

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507480


Christoph Wickert <fedora at christoph-wickert.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at christoph-wickert.de




--- Comment #9 from Christoph Wickert <fedora at christoph-wickert.de>  2009-08-02 20:38:46 EDT ---
(In reply to comment #6)

> The reason I added it because the rpm itself doesn't have libraries in it that
> can be used for determining requirements but the pre/post scripts use
> gtk-update-icon-cache which requires gtk2.  

"Note that no dependencies should be added for this. If gtk-update-icon-cache
is not available, there's nothing that would be needing the cache update, ..."
Read the whole paragraph at 
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache

BTW: You are not preserving timestamps while copying the files, see
https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
I'd rather use install instead of cp to make sure permissions are correct. If
you want to use cp, please use %attr to verify the permissions.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.