[Bug 515144] Review Request: vifir - A viewer for electronic aviation charts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515144


Peter Lemenkov <lemenkov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #2 from Peter Lemenkov <lemenkov at gmail.com>  2009-08-03 05:40:52 EDT ---
REVIEW:

+ rpmlint is silent
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec .
+ The package meets the Packaging Guidelines .
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines .
+ The License field in the package spec file matches the actual license.
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matches the upstream source, as
provided in the spec URL.

[petro at Sulaco SOURCES]$ sha256sum vifir-0.4.tar.gz*
340db9360c8f3710192fd8b773736e11c992cd3dad855ba848887a15f7d06607 
vifir-0.4.tar.gz
340db9360c8f3710192fd8b773736e11c992cd3dad855ba848887a15f7d06607 
vifir-0.4.tar.gz.1
[petro at Sulaco SOURCES]$ 

+ The package successfully compiles and builds into binary rpms on at least one
primary architecture. See link above.
+ All build dependencies are listed in BuildRequires.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code or permissible content.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
+ The packages includes a %{name}.desktop file, and that file is properly
installed with desktop-file-install in the %install section.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages must be valid UTF-8

Don't forget to add it to the list of GIS-related applications on the dedicated
wiki-page.


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.