[Bug 510734] Review Request: x11vnc - VNC server for the current X11 session

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510734





--- Comment #40 from Christian Krause <chkr at plauener.de>  2009-08-03 18:46:23 EDT ---
(In reply to comment #34)
> (In reply to comment #23)
> > But IMHO it looks bad for nearly all people since most others use tabwidth = 8.
> > Just try to click on the link in your browser and the the lines will look
> > somehow displaced. I suggest to convert it to spaces since that's a good
> > compromise and it will look good for all people. ;-)
> It is more useful when standard size - you always see where tab used, and where
> not. I suggest you change settings. I think it is easy in any editor.

The spec file should be easily readable without any specific tab width
settings. Please use either a standard tab width or convert it to spaces.

> > No, it's just a convenience / some kind of standard in Fedora.
> Can I read about similar things anywhere?

I'm not aware of any explicit documentation which requires "Source0", however
this is also some kind of standard in all Fedora packages. E.g. see the
examples here:

http://fedoraproject.org/wiki/Packaging/SourceURL

> > I've asked on #fedora-devel and I got the impression that file based build
> > requires are strongly discouraged. The main reason is the increased build time.
> > I think we must not only consider the increased build time for single
> > developers but also the increased load on the koji machines. 
> This issue discussed many times in ml, f.e.
> https://lists.dulug.duke.edu/pipermail/rpm-devel/2004-October/000097.html but
> there no 1 thing.
> 
> So, *correct* way in this case libXi-devel should provide xorg-x11-proto-devel
> as it is replaced them. Other is hacks. File-based BuildRequire is semed more
> beautiful and preferred for me.
> And, I believe what increased build time is very small to count it...

Since this seems to be discouraged in Fedora, please don't do it. The
guidelines don't explicitly forbid this, but at least for the Requires field it
is discouraged: http://fedoraproject.org/wiki/Packaging/Guidelines#Requires

> > Use the macros consistently - one plain "rm" leaked in although you've used
> > "%{__rm}" in all other places...  
> Ok.

There is one missing where your removed the prebuilt clients.

Some more remarks:

Would it be possible to link it against the regular liblzo even for the Fedora
package? This would save us one condition.
Additional if it would be possible to create a patch which would make this a
compile option to switch between minilzo (which is designed to be internal) and
external lzo then this patch would be hopefully acceptable for upstream.

The part of the %prep section which changes the encoding is not correctly
indented.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.