[Bug 507479] Review Request: moblin-cursor-theme - Moblin X cursors icon theme

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507479


Christoph Wickert <fedora at christoph-wickert.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #9 from Christoph Wickert <fedora at christoph-wickert.de>  2009-08-03 19:40:50 EDT ---
(In reply to comment #8)

> From memory of a discussion on fedora-devel the package descriptions shouldn't
> contain things like "This package contains" as by definition its a package (and
> you shouldn't mention the package name in the summary) so I've left it as is
> for the moment (except the removal of the word 'icon') due to lack of any
> current inspiration on how to describe cursors :)

I recall this discussion. Summary should be short, only keywords instead of
"foo is a bar...". %description in the other hand can be longer and should
contain complete sentences. 


> SPEC: http://pbrobinson.fedorapeople.org/moblin-cursor-theme.spec
> SRPM: http://pbrobinson.fedorapeople.org/moblin-cursor-theme-0.3-2.src.rpm

Let's see what we have:
OK - Summary and description (I still would like the description a little more
elaborate, but this is up to you.)
OK - no more disttag.
OK - '%{__mkdir_p} -p'  and %{cp} replacve with simple commands (no blocker
anyway)
OK - /usr/share no longer hardcoded
OK - Full URL of Source0 provided
OK - Sources match by md5 4e88ee79b4aafc08e4dc6defc3dadf7d

I still would prefer install over cp, but as the cursors are now being
generated during build, their permissions will be fine anyway.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.