[Bug 515463] Review Request: cxxtest - A JUnit-like testing framework for C++

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515463





--- Comment #1 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-08-04 09:18:11 EDT ---
- There's no need to Requires: python, RPM picks it up automatically. Drop it.

- The package contains python parts, so it's best to BuildRequires:
python-devel. Extract from build log:
+ exit 0
/usr/lib/rpm/pythondeps.sh: line 8: python: command not found
/usr/lib/rpm/pythondeps.sh: line 8: python: command not found

**

As this is inherently a development package, I think the headers should go into
the main package. The split is OK if you can use the files in the main package
without the -devel package being installed.

**

rpmlint output:
cxxtest-devel.noarch: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 1 warnings.

This is expected.


MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK

MUST: The spec file for the package is legible and macros are used
consistently. OK
- To be clearer I recommend changing
 %{_includedir}/*
to
 %{_includedir}/cxxtest/

MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK

MUST: The License field in the package spec file must match the actual license.
OK
- Source code contains no headers.
- README states cxxtest is under LGPL (no version stated), thus license tag is
LPGLv2+. (Since there was no LGPLv2; in case of GPL this would be GPL+.)

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. OK
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK

MUST: Header files must be in a -devel package. ?
- This is a development package, so the headers should probably be in the main
package.

MUST: Static libraries must be in a -static package. N/A
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. OK
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.