[Bug 515049] Review Request: dvisvgm - Converts DVI files to SVG
bugzilla at redhat.com
bugzilla at redhat.com
Tue Aug 4 13:32:15 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=515049
--- Comment #17 from Jussi Lehtola <jussi.lehtola at iki.fi> 2009-08-04 09:32:14 EDT ---
To make sure the package doesn't use the bundled potracelib, remove the
directory in %prep with
%prep
%setup -q
%patch0 -p 1 -b .orig
# Remove bundled potracelib
rm -rf potracelib
**
You haven't updated the SRPM to the newest spec.
Also, whenever you make changes to the spec you must bump the release tag and
make a comment in the changelog. Otherwise it's very hard for others to keep
track.
To my count the releases so far have been:
1: initial release
2: rebase to upstream with added tarball (btw, you should have made a point
release upstream :P)
3: don't use bundled potrace
so the next release should be 4. Add the missing entries to the changelog.
**
rpmlint output is clean.
MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. OK
- All files are generated in %build, no need to preserve time stamps upon
install.
MUST: Packages containing shared library files must call ldconfig. OK
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. NEEDSWORK
- Add LICENSE to %doc.
MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK
**
Fix the issues.
You can apply for packager group membership in FAS now and I'll sponsor you.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list