[Bug 510743] Review Request: aranym - Atari Running on Any Machine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510743





--- Comment #5 from Andrea Musuruane <musuruan at gmail.com>  2009-08-04 11:52:52 EDT ---
* I think that you should install the icons under
%{_datadir}/icons/hicolor/32x32/apps 
%{_datadir}/icons/hicolor/48x48/apps 

and use the following snipplets:
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

and require:
Requires:       hicolor-icon-theme

* The release number is not right according to the guidelines:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Version

* I couldn't see a MimeType key in the desktop entry. Therefore there should be
no need for the following scriptlet:

%post
update-mime-database %{_datadir}/mime &> /dev/null || :

%postun
update-mime-database %{_datadir}/mime &> /dev/null || :

* This is not required
Requires:       desktop-file-utils

* gcc-c++ is not BR. It is always included.

* SDL-devel is not BR. It is already pulled in by SDL_image-devel. There could
probabily be more devel pacakges like this. I didn't check them all.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.