[Bug 504424] Review Request: ruby-json - A JSON implementation in Ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504424





--- Comment #8 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-08-04 12:26:20 EDT ---
rubygem-json-1.1.7-1.fc10 does not build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1580525

Some notes:
* SourceURL
  - For gems, you can use:
    http://gems.rubyforge.org/gems/<gemname>-<version>.gem
    and this URL is easier.

* Gem installation process
  - The main reason the build fails like:
---------------------------------------------------
Binary file
/builddir/build/BUILDROOT/rubygem-json-1.1.7-1.fc12.x86_64/usr/lib/ruby/gems/1.8/gems/json-1.1.7/ext/json/ext/generator/unicode.o
matches
---------------------------------------------------
    is because you installs gem file under %buildroot instead
    of creating directory under %_builddir and installing gem
    file under there [1]
    This is also mentioned in current ruby guidelines [2]
    For example, please refer to rubygem-nokogiri spec file [3]

[1] https://www.redhat.com/archives/fedora-devel-list/2009-July/msg00929.html
[2]
https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Gem_with_extension_libraries_written_in_C
[3]
http://cvs.fedoraproject.org/viewvc/rpms/rubygem-nokogiri/devel/rubygem-nokogiri.spec?revision=1.11

* Enable tests
  - As this gem file installs some tests under %geminstdir/tests/,
    please enable tests (also see the example [3])

* Documents directories
  - Documents installed under %geminstdir should just be marked as %doc
    and should not be moved to under %_defaultdocdir because
    $ gem contents <gemname> expects that those files should be under
    %geminstdir.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.