[Bug 514889] Review Request: perl-Catalyst-Plugin-Session-Store-Cache - Store sessions using a Catalyst::Plugin::Cache

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=514889


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu>  2009-08-04 19:48:24 EDT ---
Generic boring Perl module review follows:

* source files match upstream.  sha256sum:
   d8ac902870fbe0916aba2b4cc9b3aa2f1a12c94ef704003cc9fb1fd6153d4112  Catalyst-
   Plugin-Session-Store-Cache-0.01.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.                                                              
* description is OK.                                                          
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   perl(Catalyst::Plugin::Session::Store::Cache) = 0.01
   perl-Catalyst-Plugin-Session-Store-Cache = 0.01-1.fc12
  =
   perl(:MODULE_COMPAT_5.10.0)
   perl(Catalyst::Plugin::Session) >= 0.06
   perl(base)
   perl(strict)
   perl(warnings)

* %check is present and all tests pass:
   All tests successful.
   Files=3, Tests=3,  1 wallclock secs
    ( 0.02 usr  0.01 sys +  0.11 cusr  0.03 csys =  0.17 CPU)
   Result: PASS

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.