[Bug 488174] Review Request: nimbus-theme-gnome - The Nimbus theme originally from Sun

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488174


Christoph Wickert <fedora at christoph-wickert.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(sundaram at redhat.c
                   |                            |om)




--- Comment #27 from Christoph Wickert <fedora at christoph-wickert.de>  2009-08-05 05:34:43 EDT ---
(In reply to comment #22)
> (In reply to comment #20)
> > %files -n nimbus-icon-theme
> > %defattr(-,root,root,-)
> > %doc AUTHORS ChangeLog COPYING
> > %{_datadir}/icons/nimbus/
> > %ghost %{_datadir}/icons/nimbus/icon-theme.cache
> > %{_datadir}/icons/nimbus/iconrc
> > %{_datadir}/icons/nimbus/*x*/
> > %dir %{_datadir}/icons/nimbus/  
> 
> Now I am really confused ... you said %{_datadir}/icons/nimbus/icon-theme.cache
> is covered by %{_datadir}/icons/nimbus/, but instead of removing this
> duplicity, you add two more of them %{_datadir}/icons/nimbus/*x*/ (which is
> certainly covered) and %dir %{_datadir}/icons/nimbus/  ???  

No, %dir %{_datadir}/icons/nimbus/ is just that directory and nothing below it.
Everything below is listed explicitly:

%ghost %{_datadir}/icons/nimbus/icon-theme.cache
%{_datadir}/icons/nimbus/iconrc
%{_datadir}/icons/nimbus/*x*/

Got it?


(In reply to comment #21)
> You should also replace the OpenSolaris logo that replaces the GNOME foot with
> the Fedora Logo or fall back to the foot one.  

Rahul, is this really necessary? IMO this is a central part of the theme, just
like the GNOME foot. Reading http://opensolaris.org/os/about/faq/trademark_faq/
and http://www.opensolaris.org/os/trademark/ there is nothing that prevents us
from shipping it.


(In reply to comment #24)
> # removing OpenSolaris branding use start-here.png from Fedora
> find $RPM_BUILD_ROOT%{_datadir}/icons/nimbus/ -name start-here.png \
>     |while read FILENAME ; do
>         NEWICON=$(echo $FILENAME \
>             |sed -e
> "s!$RPM_BUILD_ROOT.*nimbus\(.*\)\$!\.\./\.\./\.\./Fedora\1!")
>         ln -sf -v $NEWICON $FILENAME
>     done

This is a bad idea, you shouldn't link to Fedora's start-here.png. This link
will make the package require fedora-logos, without it you have dangling
symlinks.
I suggest: If you want to link to something, link to start-here.png in
gnome-icon-theme and require that package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.