[Bug 510865] Review Request: ccze - A robust log colorizer

bugzilla at redhat.com bugzilla at redhat.com
Wed Aug 5 12:17:53 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510865





--- Comment #25 from Ralf Corsepius <rc040203 at freenet.de>  2009-08-05 08:17:52 EDT ---
(In reply to comment #24)
> (In reply to comment #23)
> > > and you should use it.
> > You've got a learning curve ahead - Better concentrate on technical issues and
> > not on cosmetic issues in reviews.  
> 
> Yes, this was a minor cosmetic issue (would have been easy to fix too). I've
> worked on 130 package reviews so far, and this has been the only one using a
> different tab width.
Again, tab widths are personal preference, you can agree with or not.

That said, your personal preference is irrelevant.

Also, what might be news to apparent newcomers with only little programming
experience like you: There exist large communities of programmers who are using
other tab widths as their standard (e.g. FreeBSD uses 4, many people with
vi-background use 3, etc.)


> Having two incompatible conventions is really not very useful. 
Cosmetics are irrelevant.

> Converting the
> tabs to spaces might be a good option, since that way the tabbing is always
> correct.  
That's a newbie's bikeshed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list