[Bug 515898] Review Request: imapfilter - A flexible client side mail filtering utility for IMAP servers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515898


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.lehtola at iki.fi




--- Comment #1 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-08-06 07:54:58 EDT ---
First, be sure to read and understand
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets

Now, a few comments:

- Drop
 BuildRequires: glibc-devel gcc binutils make
as these are in the standard buildroot 
http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

- Drop the Requires: line altogether, they're automatically picked up by RPM.
http://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires

- Instead of
 ./configure -p %{_prefix} -b %{_bindir} -s %{_datadir}/imapfilter -m
%{_mandir}
use
 %configure

- Drop
 mkdir -m 755 -p ${RPM_BUILD_ROOT}%{_defaultdocdir}/%{name}-%{version}/
 cp README LICENSE ${RPM_BUILD_ROOT}%{_defaultdocdir}/%{name}-%{version}/
as you already have listed the files in %doc. (The doc directory is removed,
recreated and the files listed in %doc placed into it when %doc is processed.)

- Replace
 /usr/bin/
with %{_bindir}
 /usr/share/
with %{_datadir}
 /usr/share/man
with %{_mandir}

- You're not owning %{_datadir}/imapfilter, instead of
 /usr/share/imapfilter/account.lua
 /usr/share/imapfilter/auxiliary.lua
 /usr/share/imapfilter/common.lua
 /usr/share/imapfilter/deprecated.lua
 /usr/share/imapfilter/mailbox.lua
 /usr/share/imapfilter/message.lua
 /usr/share/imapfilter/options.lua
 /usr/share/imapfilter/regex.lua
 /usr/share/imapfilter/set.lua
you can just specify
 %{_datadir}/imapfilter/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.