[Bug 510734] Review Request: x11vnc - VNC server for the current X11 session

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510734





--- Comment #44 from Axel Thimm <axel.thimm at atrpms.net>  2009-08-06 11:42:54 EDT ---
(In reply to comment #43)
> (In reply to comment #40)
> > The spec file should be easily readable without any specific tab width
> > settings. Please use either a standard tab width or convert it to spaces.
> You are first reviewer what don't accept that. File is easy readable. This
> style of formating not covered any guidelines, as I can understand (kick me, if
> I wrong) and I want leave it as it is.

I don't want to kick anyone, but I agree with Christian, just click on the
specfile you posted and it appears with standard tabsize 8 on my browser
looking strange.

> > Would it be possible to link it against the regular liblzo even for the Fedora
> > package? This would save us one condition.
> It is possible - http://koji.fedoraproject.org/koji/taskinfo?taskID=1579635
> But it some sort of hack. Are you sure what we should do it?

That would be great, please do it! The lzo developer offers liblzo for shared
builds and minilzo for embedded static builds. The current Fedora-only
situation with a shared minilzo is awkward to say the least and should be
removed. And if you get a patch to do the same with libvncserver you will win
all my sympathy points and I will send you a truck full of good karma :)

> > Additional if it would be possible to create a patch which would make this a
> > compile option to switch between minilzo (which is designed to be internal) and
> > external lzo then this patch would be hopefully acceptable for upstream.
> There I agree with you - such option would be appreciated. But it requires some
> additional times, and I wasn't planing do that. May be in the future.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.