[Bug 516074] Review Request: jide-oss - Swing component library built on top of Java/Swing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516074


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #6 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-08-06 14:34:19 EDT ---
You don't have to create an account to check out, you can use --username guest
as implicitly pointed out in comment #1.

**

You should send the patches upstream, as they're probably needed by a lot of
people.

**

rpmlint is clean.

existing class files and jars are correctly removed in %prep.

MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK

MUST: The License field in the package spec file must match the actual license.
OK
- Excerpt from LICENSE.txt 
 JIDE Common Layer is a dual-licensed. The two licenses are GPL with classpath  
 exception and free commercial license.

 The first license is GPL with classpath exception. This is the same license 
 under which the Java platform is released. You can read the license agreement 
 from the link below.

 GPL v2: http://www.gnu.org/licenses/gpl.txt
 Classpath Exception: http://www.gnu.org/software/classpath/license.html
- SwingWorker is LGPLv2+ but that's compatible with GPLv2.

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. OK
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. N/A
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK

MUST: Large documentation files must go in a -doc subpackage. NEEDSWORK
- There is a docs/JIDE_Common_Layer_Developer_Guide.pdf, which should go into
-doc. (There's a .doc file too, but IMHO the pdf is better.)

MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK

SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. NEEDSWORK
- There is a http link to the license in LICENSE.txt, though, so this is not
necessary.

SHOULD: The package builds in mock. OK

**

The package has been

APPROVED


Before CVS import add the -doc package. (Remember, no need to define it
explicitly as noarch since the main package already is noarch.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.