[Bug 506833] Review Request: bisho - Moblin web services settings

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506833





--- Comment #7 from Peter Robinson <pbrobinson at gmail.com>  2009-08-06 20:20:14 EDT ---
(In reply to comment #6)
> (In reply to comment #4)
> > It seems I uploaded a new package and didn't update the bug. 
> 
> Peter, you have posted two different packages with the same version: 0.10.7-1.
> The one from comment #2 had a md5sum of 6cfb7ae0d1ea8fcd504ff89f50a32079, the
> one from comment comment #4 had 438f7278066fca02589fe16d26b7a80d. Please don't
> do that. Whenever you update the package, increase the release to avoid
> confusion.

The comment I made in comment #4 was the same one. I didn't upload a new one
there. Check the dates here http://pbrobinson.fedorapeople.org/

> > > - The comment "Require these because ..." is misleading. gnome-common is
> > > (likely) needed and gettext/intltool are needed because of the locales. So all
> > > that is actually required to run autogen.sh is libtool. Please change the
> > > comment to reflect this.
> > 
> > Well none of them would be needed at all if the package was a released package
> > that had "make dist" run, hence the comment. 
> 
> intltool is needed to generate the locales, gettext is needed for find_lang.sh.
> And I'm pretty sure that gnome-common is also not needed, so IMO the comment is
> still misleading.

I've needed it for gtk based apps in the past, that's why I added it. I will
investigate it tomorrow.

> > > - AUTHORS and TODO are missing from %doc. Don't add NEWS and README (empty) or
> > > ChangeLog (not useful)
> >
> > Added, they use to be empty :)
> 
> No they were not, even in 0.10.2 ;)

Maybe they were empty in one of the other many packages.

> > Not an issue, mux was in rawhide for about 2 weeks and then marked as a
> > dead.package due to being merged into nbtk.
> 
> Then please make notice of this change in the bug to save the reviewer a lot of
> time and headache.

The new package in comment #2 had it removed, sorry I assumed the latest
package would be used.

> > Also fixed up the autoconf.sh so it doesn't run configure twice.
> 
> Fine.
> 
> > SRPM: http://pbrobinson.fedorapeople.org/bisho-0.10.7-2.fc11.src.rpm
> > koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1588011  
> 
> OK, let me take a look at it. Stay tuned.  

Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.