[Bug 512729] Review Request: perl-IO-Async - A collection of modules that implement asynchronous filehandle IO

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=512729


Emmanuel Seyman <emmanuel.seyman at club-internet.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #6 from Emmanuel Seyman <emmanuel.seyman at club-internet.fr>  2009-08-07 08:16:53 EDT ---

(In reply to comment #5)
> I don't understand the problem, only the spec for 0.22 is available as
> http://kwizart.fedorapeople.org/review/perl-IO-Async.spec
> (might need to refresh the browser ?)

Probably a mistake on my part.

Review:
+ package builds in mock (F12 x86).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1588755
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
92cfc798a468e32aa1bd3d85ef1029e1  IO-Async-0.22.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
All tests successful.
Files=32, Tests=726, 31 wallclock secs ( 0.15 usr  0.06 sys +  2.45 cusr  0.66
csys =  3.32 CPU)
Result: PASS
Package perl-IO-Async-0.22-1.fc12.noarch =>
Provides: perl(IO::Async) = 0.22
          perl(IO::Async::ChildManager) = 0.22
          perl(IO::Async::Connector) = 0.22
          perl(IO::Async::DetachedCode) = 0.22
          perl(IO::Async::Handle) = 0.22
          perl(IO::Async::Listener) = 0.22
          perl(IO::Async::Loop) = 0.22
          perl(IO::Async::Loop::IO_Poll) = 0.22
          perl(IO::Async::Loop::Select) = 0.22
          perl(IO::Async::MergePoint) = 0.22
          perl(IO::Async::Notifier) = 0.22
          perl(IO::Async::Resolver) = 0.22
          perl(IO::Async::Sequencer) = 0.22
          perl(IO::Async::Signal) = 0.22
          perl(IO::Async::Stream) = 0.22
          perl(IO::Async::Test) = 0.22
          perl(IO::Async::Timer) = 0.22
Requires: perl(Carp) perl(Exporter) perl(Fcntl) perl(Heap::Fibonacci)
perl(IO::Handle) perl(IO::Poll) perl(IO::Socket) perl(POSIX) perl(Scalar::Util)
perl(Socket) perl(Socket::GetAddrInfo) perl(Storable) perl(Time::HiRes)
perl(base) perl(constant) perl(strict) perl(warnings)

+ Not a GUI application

Should:
Test::Pod should be added as a BuildRequires.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.