[Bug 515079] Review Request: perl-Config-Model - Framework to create configuration validation tools and editors

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515079


Iain Arnell <iarnell at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |iarnell at gmail.com
         AssignedTo|nobody at fedoraproject.org    |iarnell at gmail.com
               Flag|                            |fedora-review?




--- Comment #4 from Iain Arnell <iarnell at gmail.com>  2009-08-08 05:57:09 EDT ---
+ source files match upstream.  
  ea1cf6bdbcc0ee400592a44b138dba6404bc6b45  Config-Model-0.638.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
- license field matches the actual license.
  should be LGPLv2+

+ license is open source-compatible.
+ license text included.
+ latest version is being packaged.
- BuildRequires are proper.
  missing perl(Test::Pod)

+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1590883

+ package installs properly.
- rpmlint has complaints:
  perl-Config-Model.noarch: I: checking
  perl-Config-Model.noarch: W: invalid-license LGPL
  perl-Config-Model.src: I: checking
  perl-Config-Model.src: W: invalid-license LGPL
  2 packages and 0 specfiles checked; 0 errors, 2 warnings.

+ final provides and requires are sane:
  perl(Config::Model) = 0.638
  perl(Config::Model::AnyId) = 914
  perl(Config::Model::AnyThing) = 845
  perl(Config::Model::AutoRead) = 978
  perl(Config::Model::CheckList) = 978
  perl(Config::Model::Describe) = 669
  perl(Config::Model::DumpAsData) = 978
  perl(Config::Model::Dumper) = 906
  perl(Config::Model::Exception) = 790
  perl(Config::Model::Exception::Any)  
  perl(Config::Model::Exception::Load)  
  perl(Config::Model::Exception::LoadData)  
  perl(Config::Model::Exception::Model)  
  perl(Config::Model::Exception::ObsoleteElement)  
  perl(Config::Model::Exception::RestrictedElement)  
  perl(Config::Model::Exception::UnavailableElement)  
  perl(Config::Model::Exception::UnknownElement)  
  perl(Config::Model::Exception::UnknownId)  
  perl(Config::Model::Exception::WrongType)  
  perl(Config::Model::Exception::Xml)  
  perl(Config::Model::HashId) = 905
  perl(Config::Model::IdElementReference) = 775
  perl(Config::Model::Instance) = 968
  perl(Config::Model::ListId) = 861
  perl(Config::Model::Loader) = 717
  perl(Config::Model::Node) = 935
  perl(Config::Model::ObjTreeScanner) = 715
  perl(Config::Model::Report) = 641
  perl(Config::Model::Searcher) = 905
  perl(Config::Model::SimpleUI) = 541
  perl(Config::Model::TermUI) = 669
  perl(Config::Model::Value) = 978
  perl(Config::Model::ValueComputer) = 905
  perl(Config::Model::WarpedNode) = 993
  perl(Config::Model::WarpedThing) = 729
  perl(Config::Model::WizardHelper) = 790
  perl-Config-Model = 0.638-2.fc12
=
  /usr/bin/perl  
  perl(:MODULE_COMPAT_5.10.0)  
  perl(Carp)  
  perl(Carp::Assert::More)  
  perl(Carp::Assert::More)  
  perl(Config::Model)  
  perl(Config::Model::Describe)  
  perl(Config::Model::DumpAsData)  
  perl(Config::Model::Dumper)  
  perl(Config::Model::Exception)  
  perl(Config::Model::IdElementReference)  
  perl(Config::Model::Instance)  
  perl(Config::Model::Loader)  
  perl(Config::Model::Node)  
  perl(Config::Model::ObjTreeScanner)  
  perl(Config::Model::Report)  
  perl(Config::Model::Searcher)  
  perl(Config::Model::ValueComputer)  
  perl(Config::Model::WizardHelper)  
  perl(Config::Tiny)  
  perl(Data::Dumper)  
  perl(Exception::Class)  
  perl(Exception::Class)  
  perl(Exporter)  
  perl(File::Path)  
  perl(Getopt::Long)  
  perl(IO::File)  
  perl(Log::Log4perl)  
  perl(Log::Log4perl) >= 1.11
  perl(Parse::RecDescent)  
  perl(Parse::RecDescent) >= 1.90.0
  perl(Pod::Usage)  
  perl(Scalar::Util)  
  perl(Storable)  
  perl(Term::ReadLine)  
  perl(Text::Wrap)  
  perl(UNIVERSAL)  
  perl(base)  
  perl(strict)  
  perl(vars)  
  perl(warnings)  
  perl(warnings::register)  
  rpmlib(CompressedFileNames) <= 3.0.4-1
  rpmlib(FileDigests) <= 4.6.0-1
  rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  rpmlib(VersionedDependencies) <= 3.0.3-1

- %check is present and all tests pass.
  t/pod.t ................... skipped: Test::Pod 1.00 required for testing POD
  [snip]
  All tests successful.
  Files=33, Tests=989,  9 wallclock secs ( 0.17 usr  0.08 sys +  7.98 cusr 
0.78 csys =  9.01 CPU)
  Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.


Looking pretty good - just a missing BR: perl(Test::Pod), and the license tag
needs to be changed.

You could also remove a couple of the explicit Requires, but it's not strictly
necessary to do so:
  perl(Carp::Assert::More)  
  perl(Exception::Class)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.