[Bug 507223] Review Request: dalston - Moblin System Information Icons

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507223





--- Comment #14 from Christoph Wickert <christoph.wickert at googlemail.com>  2009-08-08 18:32:43 EDT ---
OK - MUST: $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/dalston-*
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
OK - MUST: named according to the Package Naming Guidelines
OK - MUST: spec file name matches the base package %{name}
OK - MUST: package meets the Packaging Guidelines
OK - MUST: Fedora approved license and meets the Licensing Guidelines: LGPLv2
and GPLv2+
FIX - MUST: License field in spec file doesnt match the actual license LGPLv2
and GPLv2
OK - MUST: license file included in %doc
OK - MUST: spec is in American English
OK - MUST: spec is legible
OK - MUST: sources match the upstream source by MD5
a0ec0af90200c7d11c418514eeba1cb1
OK - MUST: successfully compiles and builds into binary rpms on x86_64
OK - MUST: No ExcludeArch
OK - MUST: all build dependencies are listed in BuildRequires.
OK - MUST: handles locales properly with %find_lang
OK - MUST: not designed to be relocatable
OK - MUST: owns all directories that it creates
OK - MUST: no duplicate files in the %files listing
OK - MUST: Permissions on files are set properly, includes %defattr(...)
OK - MUST: package has a %clean section, which contains rm -rf %{buildroot}
OK - MUST: consistently uses macros
OK - MUST: package contains code
OK - MUST: No large documentation files
OK - MUST: Files included as %doc do not affect the runtime of the application
N/A - MUST: Header files must be in a -devel package
N/A - MUST: Static libraries must be in a -static package
N/A - MUST: Packages containing pkgconfig(.pc) files must 'Requires:
pkgconfig'.
OK - MUST: The package does not contain any .la libtool archives.
 - MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. The package contains a GUI application and includes a
%{name}.desktop file, and that file is properly installed with
desktop-file-install in the %install section.

OK - MUST: packages does not own files or directories already owned by other
packages.
OK - MUST: at the beginning of %install, the package runs rm -rf %{buildroot}
OK - MUST: all filenames valid UTF-8


SHOULD Items:
OK - SHOULD: Source package includes license text(s) as a separate file.
N/A - SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
OK - SHOULD: builds in mock.
OK - SHOULD: compiles and builds into binary rpms on all supported
architectures.
OK - SHOULD: functions as described.
FIX - SHOULD: Scriptlets not sane: you are updating icon cache although there
are no icons
N/A - SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
N/A - SHOULD:  pkgconfig(.pc) files should be placed in a -devel pkg.
N/A - SHOULD: no dependencies outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin


Other issues:
OK - latest stable version
OK - SourceURL valid
OK - Compiler flags ok
OK - Debuginfo complete


Issues:
- License field
- drop redundant glib2-devel BR
- drop Requires(post): /bin/touch
- %description does not end with dot.
- %description should be more detailed, mention power and volume
- add INSTALL='install p' to make install
- rm the autostart file instead of %exclude
- no libtool archives, so nothing to remove
- README missing from %doc
- configure is run twice, your hack doesn't work

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.