[Bug 516343] Review Request: metadata-extractor - JPEG metadata extraction framework

bugzilla at redhat.com bugzilla at redhat.com
Sun Aug 9 10:34:50 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516343





--- Comment #6 from Guido Grazioli <guido.grazioli at gmail.com>  2009-08-09 06:34:49 EDT ---
(In reply to comment #5)
> (In reply to comment #3)
> > Did you try to BuildRequire: ant-junit ? 
> > It seems you lack the jar providing junit functions to ant  
> 
> Yes, that's what I get:
> 
> [...]
> test:
>     [junit] WARNING: multiple versions of ant detected in path for junit 
>     [junit]         
> jar:file:/usr/share/java/ant-1.7.1.jar!/org/apache/tools/ant/Project.class
>     [junit]      and
> jar:file:/usr/share/java/ant.jar!/org/apache/tools/ant/Project.class
>     [junit] Running com.drew.metadata.test.AllTests
>     [junit] Tests run: 79, Failures: 1, Errors: 0, Time elapsed: 0,269 sec
> 
> BUILD FAILED
> /home/andrea/devel/prg/metadata-extractor/build.xml:48: Test
> com.drew.metadata.test.AllTests failed
> 
> Total time: 1 second
> 

You can ignore the warning (/usr/share/java/ant/ant-junit.jar is a symlink to
/usr/share/java/ant/ant-junit-1.7.1.jar); however the package fails in one of
the tests, that's probably why junit build was excluded from debian folks too. 

Which locale do you run the jvm into? The code calls a decimal number formatter
which returns "x,xx" (or "x.xx" depending on locale) instead of the expected 
"x.xx" (should work in us locales, it's bad written code however because it
makes a comparison between a value processed depending on locale with a static
string).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list