[Bug 458866] Review Request: xls2csv - A script that recodes a spreadsheet's charset and saves as CSV

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458866





--- Comment #7 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan at hubbitus.info>  2009-08-09 09:43:16 EDT ---
(In reply to comment #6)
> Therefore I think writing "make" is just as future-proof as
> "%{__make}", and it's easier to read. The macros aren't forbidden though, as
> far as I know.
I thought about it.

> > But rpmbuild don't add next requires:
> > perl(:MODULE_COMPAT_5.10.0)
> 
> You should keep that one, according to the guidelines.
Ok.

> > perl-Unicode-Map or perl(Unicode::Map)
> perl-Spreadsheet-ParseExcel depends on perl(Unicode::Map), so you get that
> pulled in by the automatic dependency on perl(Spreadsheet::ParseExcel)
Hm... Such dependency may be broken in the future. Imagine:
perl(Spreadsheet::ParseExcel) in the future may change implementation to do not
use perl(Unicode::Map). Therefore, it is not mean what this package not use it
also. So, I think it Requires: perl(Unicode::Map) should be explicit there.

> When I build the package I get an automatic dependency on perl(Locale::Recode),
> which perl-libintl provides.
Ok, I wasn't saw that.

> > Sorry, I don't want change tabs to spaces.
> Well, if this is what you want others to see when they read your spec, it's
> your choice:
> http://www.rombobjörn.se/diverse/xls2csv.png
> It is a requirement that the spec be legible, but this misalignment isn't bad
> enough to make it illegible, so I suppose it's allowed.  
Please, see explanations of Ralf Corsepius there -
https://bugzilla.redhat.com/show_bug.cgi?id=510865#c23 . In any case I can't
say more. Please keep in mind - I am very grateful that he came, but I did not
ask him about it myself.

BTW, Björn Persson, thank you for the help. Half way done, don't you want
review this package?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.