[Bug 516340] Review Request: fupt - Fedora Unity Paste tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516340


Ralf Corsepius <rc040203 at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203 at freenet.de




--- Comment #5 from Ralf Corsepius <rc040203 at freenet.de>  2009-08-09 12:31:20 EDT ---
(In reply to comment #4)
> Approved

Do you think this was a wise decision? I don't. IMO, this package is not ready
of public consumption.


Rationale:

- No understandable documentation.

I have never heard about fpaste.org before, don't why I would want to access
it, nor do I understand what this package does nor why I would want to install
it.

- Very immature implementation of the script.
 * No "usage()", no support for --help.
 * Naming a script *.sh is unnessary on Unix.
 * Using a "4 letter" name such as fupt for such a script is not
   necessarily a wise decision.

- Improper upstream packaging (no tarball, no versions, ... 
  ... part of this (as you already mentioned: improper licensing).


- The script is unsafe:

if [ ! -e /usr/bin/curl ]; then
...
  cat $1 | curl -s -i -F "content=<-;type=text/plain" ..
...
Note: It tests for /usr/bin/curl but runs "curl".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.