[Bug 516343] Review Request: metadata-extractor - JPEG metadata extraction framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516343





--- Comment #8 from Andrea Musuruane <musuruan at gmail.com>  2009-08-10 02:13:46 EDT ---
(In reply to comment #6)

> Which locale do you run the jvm into? The code calls a decimal number formatter
> which returns "x,xx" (or "x.xx" depending on locale) instead of the expected 
> "x.xx" (should work in us locales, it's bad written code however because it
> makes a comparison between a value processed depending on locale with a static
> string).  

I'm using an Italian locale.

(In reply to comment #7)
> You can patch build.xml in the top directory:
> ----
> 48a49
> >             <jvmarg value="-Duser.language=en -Duser.country=US"/>
> ----
> 
> to make junit tests complete successfully, and send the patch upstream.  

Thanks for the patch. I can successfully compile metadata-extractor outside
rpmbuild. In rpmbuild I still have an error in the junit tests, although
different:

[...]
 Testcase: testUserCommentDescription_AsciiHeaderExtendedAsciiEncoding took
0.002
 sec
        FAILED
expected:<...extended characters [??? ???]> but was:<...extended characters
[???
 ???]>
junit.framework.ComparisonFailure: expected:<...extended characters [??? ???]>
b
ut was:<...extended characters [??? ???]>
        at
com.drew.metadata.exif.test.ExifDescriptorTest.testUserCommentDescrip
tion_AsciiHeaderExtendedAsciiEncoding(Unknown Source)

This is quite strange. I diff'ed the sources and they seem the same. I need to
investigate this further.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.