[Bug 516466] Review Request: sys_basher - multi-threaded hardware tester

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516466


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841(FE-NEEDSPONSOR)




--- Comment #2 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-08-10 02:51:38 EDT ---
Blocking FE-NEEDSPONSOR.

To get this package in Fedora you will need to get a sponsor. I can sponsor you
if you show me that you know the Fedora guidelines, most importantly
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets

To do this you need to perform a couple of informal package reviews of packages
of other people. You should also make another submission.

**

A few notes:

- The tabbing of the spec file does not look sane. Please fix it.

- License tag is incorrect, should be BSD with advertising.
http://fedoraproject.org/wiki/Licensing#Software_License_List

- Package does not build in mock; you are missing at least BuildRequires:
ncurses-devel.

- Explicit Requires: are not allowed, so drop the Requires line altogether.
http://fedoraproject.org/wiki/Packaging/Guidelines

- You shouldn't need to
 mkdir -p $RPM_BUILD_ROOT
 mkdir -p $RPM_BUILD_ROOT%{_sbindir}
as this should be done by make install.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.