[Bug 514150] Review Request: ibus-qt - The qt support tools for ibus

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=514150


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #3 from Parag AN(पराग) <panemade at gmail.com>  2009-08-10 06:48:16 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1578478
- rpmlint is NOT silent for RPM.
ibus-qt.i686: W: one-line-command-in-%post /sbin/ldconfig
You should use %post -p <command> instead of using:  %post <command>  It will
avoid the fork of a shell interpreter to execute your command as well as
allows rpm to automatically mark the dependency on your command for the
excecution of the scriptlet.

ibus-qt.i686: W: one-line-command-in-%postun /sbin/ldconfig
You should use %postun -p <command> instead of using:  %postun <command>  It
will avoid the fork of a shell interpreter to execute your command as well as
allows rpm to automatically mark the dependency on your command for the
excecution of the scriptlet.

+ source files match upstream url
b3ed5e0bcbab7c88f9745e8fc83ac10d684ed9ce  ibus-qt-1.2.0.20090728-Source.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ ldconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package ibus-qt-1.2.0.20090728-1.fc12.i686 =>
Provides: libibus-qt.so.1 libqtim-ibus.so
Requires: libQtCore.so.4 libQtDBus.so.4 libQtGui.so.4 libc.so.6
libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) libdbus-1.so.3
libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libibus-qt.so.1 libm.so.6 libpthread.so.0
librt.so.1 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3)
libstdc++.so.6(GLIBCXX_3.4) rtld(GNU_HASH)
+ Package ibus-qt-devel-1.2.0.20090728-1.fc12.i686 =>
Requires: libibus-qt.so.1
+ Not a GUI application

Suggestions:
1)Fix rpmlint messages before cvs import.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.