[Bug 516466] Review Request: sys_basher - multi-threaded hardware tester

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516466


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |182235(FE-Legal)




--- Comment #7 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-08-10 10:48:44 EDT ---
(In reply to comment #3)
> This is my first package. 
> 
> I generated the .spec file using rpmdev-newspec and then edited it with Xemacs,
> the tabs look fine to me. 

When I look at the spec in xemacs I see that Group:, URL: and License:  are not
aligned with the rest of the lines. As far as I can tell this is not a tab
width issue since those are spaces, not tabs, in the spec file. Anyway, this is
just an esthetical issue.

> rpmbuild doesn't seem to work without the mkdirs, is it expecting them in
> Makefile?

Yes, normally makefiles have them. As you are upstream, you should add them to
the sys_basher release.

> My license is the original BSD. I have advertising on my sys_basher website for
> my products and services but there is none in the program or in the source
> package.

Yes, original BSD, i.e. 4 clause BSD is marked in Fedora as "BSD with
Advertising" as you could have seen from the link in comment #2. It is *NOT*
compatible with GPL. As lm_sensors is under GPLv2+, including this package in
Fedora at the moment would break licensing. Blocking FE-LEGAL.

> The program requires lm_sensors, is rpmbuild smart enough to figure that out
> from the source code?

Yes, rpm checks out everything that has been compiled dynamically and requires
the relevant libraries.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.