[Bug 507299] Review Request: network-manager-netbook - Moblin Netbook GUI for NetworkManger

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507299





--- Comment #9 from D. Marlin <dmarlin at redhat.com>  2009-08-10 13:00:34 EDT ---

This package does not yet build due to missing dependencies:

--------
checking for NMN... configure: error: Package requirements (dbus-glib-1 >= 0.75
gtk+-2.0 gconf-2.0 gnome-keyring-1 libnm-util libnm_glib
mobile-broadband-provider-info) were not met:
No package 'mobile-broadband-provider-info' found
--------

Perhaps mobile-broadband-provider-info should be added to the "BuildRequires"
list.

In the meantime, I did a preliminary review of the spec file and found a few
issues/questions:


1)  * MUST: The License field in the package spec file must match the actual
license.

  License:        GPLv2+

but the COPYING file in the latest source RPM explicitly states "Version 3":

  GNU GENERAL PUBLIC LICENSE
   Version 3, 29 June 2007


2)  * MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.

I think the comment and URL field in the spec should be:

# git clone git://git.gnome.org/network-manager-netbook

URL:    http://git.gnome.org/cgit/network-manager-netbook/


3)  * MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.

There are library files with a suffix in the files list, but no -devel package.
 Should one be added?


4)  * MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.

I believe this needs to be added to the spec file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.