[Bug 509445] Review Request: sblim-cmpi-rpm - CIM access to rpm and other information about installed packages

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=509445





--- Comment #11 from Martin Gieseking <martin.gieseking at uos.de>  2009-08-11 05:38:01 EDT ---
Of course, you may apply patches to the sources but you must not change the
tarball from upstream. Otherwise it's hard to check its validity.
Let rpmbuild do the work for you. Place the patch file into the SOURCES folder
of your rpmbuild directory and add a Patch0 and a %patch0 entry to your spec
file (this already seems to be done). rpmbuild will add the patch file to the
SRPM and will apply it when creating the binary RPM.
So again, don't change the tarball (or other upstream files) directly.


Some minor things you should fix:

- Add a short comment above Patch0 on what the patch does

- change the two lines 
  rm -rf $RPM_BUILD_ROOT/%{_libdir}/cmpi/*.la
  rm -rf $RPM_BUILD_ROOT/%{_libdir}/*.la 

  into these:

  rm -f $RPM_BUILD_ROOT/%{_libdir}/cmpi/*.la
  rm -f $RPM_BUILD_ROOT/%{_libdir}/*.la 

  (the -r option is not necessary because you want to delete files here)


- The description text is a bit unclear. At least, I didn't understand what the
package contains before reading the info on the upstream website. Please use
the complete text from upstream: 

  These providers list the software packages (currently for RPM) installed on   
  GNU/Linux systems and provide some detail information about them. 

Since the text is longer than 80 characters, split it to several lines.

- in the changelog, add a blank between ">" and "-": 
  Mon Jul 13 2009 Praveen K Paladugu <praveen_paladugu at dell.com> - 1.0.1-2
  Thu Jul 02 2009 Praveen K Paladugu <praveen_paladugu at dell.com> - 1.0.1-1

  (see http://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.