[Bug 507223] Review Request: dalston - Moblin System Information Icons

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507223





--- Comment #16 from Peter Robinson <pbrobinson at gmail.com>  2009-08-11 08:46:10 EDT ---
>From Christoph the following are fixed:
- License field
- drop redundant glib2-devel BR
- drop Requires(post): /bin/touch
- %description does not end with dot.
- %description should be more detailed, mention power and volume
- add INSTALL='install p' to make install
- no libtool archives, so nothing to remove
- README missing from %doc

These are modified:
- rm the autostart file instead of %exclude
* Upstream has fixed these to add OnlyShowIn=MOBLIN; so it will only start in
the Moblin Desktop so I've added them back in. This has the issues that desktop
file validation won't work. Trying to ascertain the status of getting MOBLIN
added into the upstream package.

>From Ralf the following are fixed:
- MUSTFIX: Make rules are non-verbose

>From both I'm investigating these further, will fix/send upstream as
appropriate:
- Using wrong autotools
- broken Makefile.am
- configure is run twice, your hack doesn't work
* disabled for the moment. Will re-enable once I've had time to investigate it
further.

Updated files as follows:
SPEC: http://pbrobinson.fedorapeople.org/dalston.spec
SRPM: http://pbrobinson.fedorapeople.org/dalston-0.0.29-2.fc11.src.rpm
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1597693

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.