[Bug 516466] Review Request: sys_basher - multi-threaded hardware tester

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516466





--- Comment #23 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-08-11 09:51:21 EDT ---
- Your changelog is not ordered in time. Fix it.

**

+ make -j4
gcc -O2 -Wuninitialized -Wformat -Wno-multichar -Wreturn-type -Wswitch -g  -c
sys_main.c 
gcc -O2 -Wuninitialized -Wformat -Wno-multichar -Wreturn-type -Wswitch -g  -c
sys_utils.c 
gcc -O2 -Wuninitialized -Wformat -Wno-multichar -Wreturn-type -Wswitch -g  -c
sys_disk.c 
gcc -O2 -Wuninitialized -Wformat -Wno-multichar -Wreturn-type -Wswitch -g  -c
sys_kernel.c 
gcc -O2 -Wuninitialized -Wformat -Wno-multichar -Wreturn-type -Wswitch -g  -c
sys_fp.c 
gcc -O2 -Wuninitialized -Wformat -Wno-multichar -Wreturn-type -Wswitch -g  -c
sys_int.c 
gcc -O2 -Wuninitialized -Wformat -Wno-multichar -Wreturn-type -Wswitch -g  -c
sys_mem.c 
gcc -O2 -Wuninitialized -Wformat -Wno-multichar -Wreturn-type -Wswitch -g  -c
lin_utils.c 
./build_sensors.csh
make[1]: Entering directory `/builddir/build/BUILD/sys_basher-1.1.17'
make[1]: warning: jobserver unavailable: using -j1.  Add `+' to parent make
rule.
gcc -O2 -Wuninitialized -Wformat -Wno-multichar -Wreturn-type -Wswitch -g  -c
sys_sensors3.c 
make[1]: Leaving directory `/builddir/build/BUILD/sys_basher-1.1.17'
gcc -O2 -Wuninitialized -Wformat -Wno-multichar -Wreturn-type -Wswitch -g  -lm
-pthread -lsensors -lform  -o sys_basher sys_main.o sys_utils.o sys_disk.o
sys_kernel.o sys_fp.o sys_int.o sys_mem.o lin_utils.o sys_sensors_x.o
/usr/bin/ld: cannot find -lform

You don't need libform anymore if you've dropped ncurses support.

**

Your %doc line is empty, add README and COPYRIGHT to %doc.  

**

The build process does not use the Fedora optimization flags. Use
 make %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS"
instead of
 make %{?_smp_mflags}
to fix this.

**

Doesn't this program work as a normal user? Change all occurrences of
%{_sbindir} to %{_bindir}.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.