[Bug 516466] Review Request: sys_basher - multi-threaded hardware tester

bugzilla at redhat.com bugzilla at redhat.com
Tue Aug 11 16:08:19 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516466





--- Comment #28 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-08-11 12:08:18 EDT ---
(In reply to comment #27)
> I'm not getting any rpmlint errors, however I'll shorten those lines anyway. 

As you can see, I get them from the SRPM, not the spec file.

> Is install a script of yours? There is no such command as install on my system
> and I don't see it in yumex.

install is a standard *nix utility:
$ rpm -qf /usr/bin/install
coreutils-7.2-2.fc11.x86_64

> I've created a man page, where do I specify?  

In the upstream makefile you should have

------
BINDIR=/usr/local/bin
MANDIR=/usr/local/share/man/
INSTALL="install -p"

install:
         $(INSTALL) -D -m 644 sys_basher.1
$(DESTDIR)$(MANDIR)/man1/sys_basher.1
         $(INSTALL) -D -m 755 sys_basher $(DESTDIR)$(BINDIR)/sys_basher
------

In the spec file you run
 make install DESTDIR=$RPM_BUILD_ROOT BINDIR=%{_bindir} MANDIR=%{_mandir}
and just add
 %{_mandir}/man1/sys_basher.1.*
in %files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list