[Bug 513848] Review Request: fbzx - A ZX Spectrum emulator for FrameBuffer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513848


Hans de Goede <hdegoede at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?




--- Comment #2 from Hans de Goede <hdegoede at redhat.com>  2009-08-11 16:17:15 EDT ---
Full review done, results:

MUST FIX:
---------
* You (correcty IMHO, esp as the icon is zgv) include icon cache scriptlets,
  but you install the icon under /usr/share/pixmaps instead of under
  /usr/share/icons/hicolor/scalable/apps

  Don't forget to add a Requires: hicolor-icon-theme for dir ownership
  when you fix this

SHOULD FIX:
-----------
* Please use "install -p -m ..." instead of "install -m ..." when installing
  non generated files to preserve the timestamps (for the keymap.bmp and
  fbzx.svg files)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.