[Bug 516364] Review Request: xrdp - Open source remote desktop protocol (RDP) server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516364


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #7 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-08-12 13:21:33 EDT ---
For -2:

The following issues on comment 2 are not yet addressed:
(In reply to comment #2)
> * Miscs
>   - In comments or %changelog, please use %% instead of % to avoid
>     macros expansion.
> 
> * Files
>   - Please example what package should own the directory
>     %_datadir/xrdp

* Naming
  - Would you clearify if this is the "post" version of 0.5.0
    or "pre" version of 0.5.0 (i.e. has 0.5.0 already been
    released)?  If this is the "pre" version. the release
    number should be "0.X.%{cvs_related_tag}%{?dist}":
   
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages

! Requires
  - Note that Fedora tightvnc-server has "Provides: vnc-server", so
    even on Fedora "Requires: vnc-server" should be enough.

* Macros
-------------------------------------------------------------------
#install /etc/rc.d/init.d/xrdp, use %{_sysconfdir}/rc.d/init.d because On
releases older
-------------------------------------------------------------------
  - You can use:
-------------------------------------------------------------------
%{!?initddir: %global initddir %{_sysconfdir}/rc.d/init.d}
-------------------------------------------------------------------

! Creating rsakeys.ini
  - (First of all, please use macros: /etc -> %_sysconfdir)
    https://fedoraproject.org/wiki/Packaging/RPMMacros

  - The following command
--------------------------------------------------------------------
%install
....
xrdp-keygen xrdp %{buildroot}/etc/xrdp/rsakeys.ini
--------------------------------------------------------------------
    won't work because xrdp is not yet installed (under the system
    structure). If rsakyes.ini is to be created here, something like:
--------------------------------------------------------------------
%install
.....
export LD_LIBRARY_PATH=%{buildroot}%{_libdir}/xrdp
export PATH=%{buildroot}%{_bindir}:$PATH
xrdp-keygen xrdp %{buildroot}/etc/xrdp/rsakeys.ini

chmod 644 %{buildroot}/etc/xrdp/rsakeys.ini
--------------------------------------------------------------------
    is needed.
    However, while I am not familiar with xrdp, is it expected that
    all machines using Fedora have the same rsakeys.ini? (again
    I don't know well how this rsakeys.ini is used)
    If not, this script should be moved to %post (and some hacks
    like marking rsakeys.int as %verify(not md5,....) or so is
    needed).

* sysinit
--------------------------------------------------------------------
[root at localhost ~]# ps auwwx | grep xrdp
root     15211  0.0  0.1   5332   824 pts/5    S+   02:09   0:00 grep xrdp
[root at localhost ~]# service xrdp status
xrdp is running
--------------------------------------------------------------------
  - ??
--------------------------------------------------------------------
[root at localhost ~]# service xrdp start
Starting: xrdp and sesman . . [root at localhost ~]# 
--------------------------------------------------------------------
  - There should be the output like [OK] and the cursor should be
    moved to the new line.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.