[Bug 516466] Review Request: sys_basher - multi-threaded hardware tester

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516466





--- Comment #38 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-08-12 13:23:40 EDT ---
And here's the review of this package:

rpmlint output:
sys_basher.src: W: strange-permission sys_basher.spec 0770
sys_basher.x86_64: W: incoherent-version-in-changelog 1.1.9-1 ['1.1.19-1.fc11',
'1.1.19-1']
3 packages and 0 specfiles checked; 0 errors, 2 warnings.

Still, the spec file you used to generate the srpm has strange permissions. Run
chmod 644 on it and regenerate the srpm. Fix the version in the changelog as
well.


MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
OK

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. NEEDSWORK
- You need to fix the source URL:
$ spectool -g sys_basher.spec 
--2009-08-12 20:20:24-- 
http://www.polybus.com/sys_basher/sys_basher-1.1.19.tar.gz
Resolving www.polybus.com... 38.113.1.181
Connecting to www.polybus.com|38.113.1.181|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2009-08-12 20:20:25 ERROR 404: Not Found.


MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. OK
- During compilation I get
 sys_disk.c: In function 'fileWrite':
 sys_disk.c:150: warning: implicit declaration of function 'open'
you might want to fix this.

MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.