[Bug 507695] Review Request: python-sqlalchemy0.5 - Modular and flexible ORM library for python

bugzilla at redhat.com bugzilla at redhat.com
Wed Aug 12 22:44:53 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507695


Toshio Ernie Kuratomi <a.badger at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #15 from Toshio Ernie Kuratomi <a.badger at gmail.com>  2009-08-12 18:44:52 EDT ---
easy_install.pth no longer conflicts.  Package builds in koji.

Two problems that you can fix when you import the package:

There's a new version sqlalchemy-0.5.5 that you might want to update to before
pushing this to EPEL for the first time.  0.5.5 contains a rarely used API
breaking change so getting it into the first release will make sure that no one
is depending on the old behaviour if you need to update later.

The egg info files are executable.  I believe this is a bug in
python-setuptools that I submitted a patch for and was fixed for Fedora but
it's still plaguing the RHEL5 version of setuptools.  You can probably change
your chmod line like this:

- find $RPM_BUILD_ROOT%{python_sitelib} -name '*.py' | xargs chmod -x
+ chmod -R a-X $RPM_BUILD_ROOT%{python_sitelib}

Since there shouldn't be any scripts under %{python_sitelib}.

Provided you make those two changes when you import, this package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list