[Bug 514342] Review Request: rubygem-fattr - Fatter attribute for Ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=514342


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #4 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-08-13 03:58:46 EDT ---
Approving, provided:

- Please add the following text file as %doc:
  http://codeforpeople.com/lib/license.txt
  (In the spec file add this with _full URL_ like
------------------------------------------------------------------
URL:            http://rubyforge.org/projects/codeforpeople/
Source0:        http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem
Source1:        http://codeforpeople.com/lib/license.txt
...
...
%install
rm -rf %{buildroot}
mkdir -p %{buildroot}%{gemdir}
...
...
install -p -m 644 %{SOURCE1} %{buildroot}%{geminstdir}/
...
...
%files
...
%doc %{geminstdir}/license
....
------------------------------------------------------------------

- If we say "the license is the same as Ruby's", on Fedora this
  means it is licensed under "GPLv2 or Ruby" (on Fedora "Ruby" license
  means the lines below "or the conditions below:" of
  http://www.ruby-lang.org/en/LICENSE.txt), so please
  change the license tag to "GPLv2 or Ruby" (not GPLv2+ or)

-----------------------------------------------------------------
    This package (rubygem-fattr) is APPROVED by mtasaka
-----------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.