[Bug 517366] Review Request: emacs-haskell-mode - Haskell editing mode for Emacs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517366





--- Comment #1 from Shakthi Kannan <shakthimaan at gmail.com>  2009-08-13 13:13:32 EDT ---
#01 It should be:

Patch0:
Patch1:

with capital 'P'.

#02 Don't rename the source file. Although the latest sources say
haskell-mode.tar.gz, please use the exact version:

  haskell-mode-2.4.tar.gz

You have mentioned the same in the .spec file as "Version: 2.4"

#03 You should add the "-b .patch" extension when applying "%patch -p1"

#04 In the Makefile patch, substitute install command with a variable, like:

INSTALL = /usr/bin/install

#05 Put the 'clean' target in the Makefile as the last target, at the bottom.

#06 Please remove control characters in haskell-site-file.el (^L), and check
for the same in other files.

#07 Don't include ~ files in the source package!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.