[Bug 517191] Review Request: php-symfony-symfony - Open-Source PHP Web Framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517191





--- Comment #6 from Christof Damian <christof at damian.net>  2009-08-13 15:23:51 EDT ---
(In reply to comment #5)
> Is this essentially the same thing as bug 351441?  Do the same issues which
> caused the closure of that review still apply?  

I didn't see that bug. But I guess they still apply. I had a quick grep through
the sources and found these in the vendor directories:

./lib/plugins/sfCompat10Plugin/lib/vendor: phpmailer
./lib/plugins/sfDoctrinePlugin/lib/vendor: doctrine
./lib/plugins/sfPropelPlugin/lib/vendor: phing,  propel,  propel-generator
./lib/vendor: lime

- phpmailer, phing, propel and propel-generator are already available in
Fedora. 
- doctrine isn't.
- lime is just used by symfony anyway, as far as I know. It is just one file.

Personally I think it is not a big problem, because symfony requires certain
versions of the libraries. For example if I create a doctrine package of the
current 1.1 it probably won't work with symfony 1.2. 

I would suggest bringing symfony into Fedora as is, with the plan to remove
these duplicated libraries in one of the next releases where possible. I think
this was how it was done in other packages which bundled libraries.

Then I probably would:
- remove the sfCompat10Plugin with the ancient phpmailer completely. 
- create the doctrine package, which I planned anyway.
- check if symmfony works with the fedora propel & phing packages. If it
doesn't I would remove that plugin too.
- create a patch to make symfony look at the default library locations instead
of vendor directories.

Thank god I don't have to think about EPEL, because RHEL is still stuck at PHP
5.1 .

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.