[Bug 517466] Review Request: lbreakout2 - A breakout-style arcade game for Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517466


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.lehtola at iki.fi




--- Comment #1 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-08-14 04:38:54 EDT ---
A few notes:

- The description is nonsense. Use e.g.
"The successor to LBreakout offers you a new challenge in more than 50 levels
with loads of new bonuses (goldshower, joker, explosive balls, bonus magnet
...), maluses (chaos, darkness, weak balls, malus magnet ...) and special
bricks (growing bricks, explosive bricks, regenerative bricks ...). If you are
still hungry for more after that you can create your own levelsets with the
integrated level editor."

- The comments to your patches are missing. Add them. Send the patches
upstream.

- Add INSTALL="install -p" to make install to preserve time stamps. Use 
'cp -p' instead of 'cp' for the same reason.

- Don't mix %{name} and lbreakout2 in %files - use one or the other and stick
with it.

- Remove the docdir created by install; just list the necessary files as %doc.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.