[Bug 517466] Review Request: lbreakout2 - A breakout-style arcade game for Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517466





--- Comment #2 from Stjepan Gros <stjepan.gros at gmail.com>  2009-08-14 12:16:39 EDT ---
(In reply to comment #1)

> - The description is nonsense. Use e.g.
> "The successor to LBreakout offers you a new challenge in more than 50 levels
> with loads of new bonuses (goldshower, joker, explosive balls, bonus magnet
> ...), maluses (chaos, darkness, weak balls, malus magnet ...) and special
> bricks (growing bricks, explosive bricks, regenerative bricks ...). If you are
> still hungry for more after that you can create your own levelsets with the
> integrated level editor."

Fixed.

> - The comments to your patches are missing. Add them. Send the patches
> upstream.

I sent them upstream, but I doubt anything will happen as the maintainter
leaved message in January on the sourceforge page that he's taking break the
next few months/years...

Comments should go where?

> - Add INSTALL="install -p" to make install to preserve time stamps. Use
> 'cp -p' instead of 'cp' for the same reason.

Fixed (I hope).

> - Don't mix %{name} and lbreakout2 in %files - use one or the other and stick
> with it.

Changed two lines: '%{_datadir}/%{name}' and '%doc %{_docdir}/%{name}'. Hope
that's it?

> - Remove the docdir created by install; just list the necessary files as %doc.

You mean by issuing 'rm -rf' on that directory? Otherwise, I have to generate
the patch to prevent doc installation by 'make install'. That probably wont be
accepted upstream...

Spec URL:
http://www.zemris.fer.hr/~sgros/stuff/fedora/lbreakout2/lbreakout2.spec
SRPM URL:
http://www.zemris.fer.hr/~sgros/stuff/fedora/lbreakout2/lbreakout2-2.6-0.2.beta7.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.