[Bug 516971] Review Request: tokyotyrant - A network interface to Tokyo Cabinet

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516971


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #2 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-08-14 14:39:45 EDT ---
Some notes:

! About tokyocabinet dependency
  - Note that current latest package of tokyocabinet on koji
    is tokyocabinet-1.4.30-1.fc12
    ( This already exists in koji dist-f12 buildroot, but has not
      pushed to rawhide tree yet because of F12alpha freeze )

* Package name
  - Usually development related package should be named as
    "tokyotyrant-devel", not "tokyotyrant-libs-devel" (even if
    you create tokyotyrant-libs package)

* About removing rpath
  - Please avoid to use "chrpath" binary as much as possible
    for removing rpath but use more "standard" method
    ( Using chrpath --delete should be thought as the last
      resort, which is usually not needed ).

    For this package replacing "LD_RUN_PATH" with "LD_LIBRARY_PATH"
    should remove rpath without using chrpath

* Macros
  - Use %_initddir for %_sysconfdir/rc.d/init.d
   
https://fedoraproject.org/wiki/Packaging/SysVInitScripts#Initscripts_on_the_filesystem

* About %_libdir/ttskel*.so
  - Would you explain how these binaries are used?
    * Actually these binaries don't have sonames, don't have the names
"libfoo.so",
      so these don't seem to be system-wide libraries.
      I suggest at least these libraries should be moved to package-specific
      directory (like %_libdir/%name)
    * Also I tried to find out how these binaries are used by using grep,
however
      it seems these binaries are used nowhere...

* %files
  - You don't have to add "COPYING" to all binary packages (only including
    to -libs package is enough because -libs package is needed by all
    packages)
    By the way README, THANKS or so should also be moved to -libs subpackage
    because tokyotyrant (binary rpm) depends on -libs subpackage and not
    opposite.

* Dependency
  - Main package must have strict dependency 
    "Requires: %{name}-libs = %{version}-%{release}"

  - For example installed /usr/include/tcrdb.h contains:
---------------------------------------------------------------
    30  #include <tcutil.h>
    31  #include <tcadb.h>
---------------------------------------------------------------
    so at least tokyotyrant-devel should have "Requires: tokyocabinet-devel".
    And tokyotyrant.pc should have "Requires: tokyocabinet".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.