[Bug 514928] Review Request: rubygem-fastercsv - FasterCSV is CSV, but faster, smaller and cleaner

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=514928


Jan Klepek <jan.klepek at hp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(redhat-bugzilla at l
                   |                            |inuxnetz.de)




--- Comment #5 from Jan Klepek <jan.klepek at hp.com>  2009-08-15 06:19:43 EDT ---
1] 
license:
there is setup.rb which is LGPL
reflect it in spec file with appropriate comment
https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios

*rpmlint ok
*ruby guidelines ok
*legible & english spec file
*naming ok
*directory ownage & files section ok
*clean/install section & macros ok
*utf-8 ok

conclusion: License needs to be corrected, otherwise it looks ok

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.