[Bug 464141] Review Request: perl-Text-Trac - Perl extension for formatting text with Trac Wiki Style

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464141


Jan Klepek <jan.klepek at hp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jan.klepek at hp.com




--- Comment #8 from Jan Klepek <jan.klepek at hp.com>  2009-08-15 09:10:50 EDT ---
Hi Timon,

1]
please bump everytime you provide new version of package release number and
post links to new version in your reply

2]
%defattr(0644,root,root,0755)
do you have any reason why not to use %defatter(-,root,root,-) ?
https://fedoraproject.org/wiki/Packaging/Guidelines#File_Permissions

3] cp in makefile is without -p switch, write patch that cp in Makefile will be
performed with -p switch (sed during prep will be good enough)
https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

4]
BuildRequires:  perl(Test::Pod::Coverage)
BuildRequires:  perl(Test::Pod)

you have to include this as without it, not all tests are performed and you
break this guideline:
https://fedoraproject.org/wiki/Packaging:Perl#Perl_Packaging

Hi Marcela,

official review for new packagers which are not yet sponsored must be done by
sponsor.

http://fedoraproject.org/wiki/Package_Review_Process#Reviewer
I think that you should keep this ticket unassigned until Timon is sponsored.
That sponsors will see that this ticket needs attention and is not assigned.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.