[Bug 516717] Review Request: viewnior - Elegant Image Viewer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516717





--- Comment #8 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-08-16 05:29:21 EDT ---
(In reply to comment #7)
> (In reply to comment #6)
> > Drop the conditional
> >  %if 0%{?_with_gnome:1}
> > as we don't use these in Fedora. 
> 
> We do use similar conditionals and I see no reason why I should drop this. It's
> an additional feature for people who want to rebuild the package and it allows
> me to easily change the default behavior.  

I haven't seen any other packages using conditionals for support of packages.
In SuSe it's common behavior and I think that some packages in RPMFusion, too,
use them, but not in Fedora. Might you give some examples?

You should enable support for everything in the package in Fedora.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.