[Bug 517743] Review Request: PyPE - Lightweight but powerful graphical editor for developers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517743





--- Comment #2 from Sandro Mathys <sm at sandro-mathys.ch>  2009-08-17 06:05:03 EDT ---
Hi Jussi, thanks for the initial review!

(In reply to comment #1)
> Remove the shebang, Python libraries don't need it.

Okay :)

> A few things to correct:
> 
> - Use the safer, time stamp keeping versions of the conversion tricks from
>  http://fedoraproject.org/wiki/PackagingTricks#Convert_encoding_to_UTF-8
> and
>  http://fedoraproject.org/wiki/PackagingTricks#Remove_DOS_line_endings

Hmm...what I'm using is actually what I was told to use in another review, but
I'll look into this tricks :)

> - Don't install manually - use setup.py to do the install. Have a look at the
> sample python spec
>  $ rpmdev-newspec python

Well, I did use the python spec-template. The thing is: there is no `setup.py
install` that does this thing for you and if you try to do it like that, you
only get the information that you should just copy the directory to wherever
you want to execute it from.

> - You need to own
>  %{python_sitelib}/%{name}/
> not
>  %{python_sitelib}/%{name}/*

Good catch!

I'll implement those changes ASAP, whenever I've got some minutes :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.