[Bug 516971] Review Request: tokyotyrant - A network interface to Tokyo Cabinet

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516971





--- Comment #4 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-08-17 12:29:17 EDT ---
For -2:

* Timestamps
  - Forgot to mention, however when using "install" or
    "cp" commands, add "-p" option to keep timestamps on
    installed files:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

* Dependency/pkgconfig file
  - And please address the below:
(In reply to comment #2)
>   - For example installed /usr/include/tcrdb.h contains:
> ---------------------------------------------------------------
>     30  #include <tcutil.h>
>     31  #include <tcadb.h>
> ---------------------------------------------------------------
>     so at least tokyotyrant-devel should have "Requires: tokyocabinet-devel".
>     And tokyotyrant.pc should have "Requires: tokyocabinet".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.