[Bug 517977] Review Request: synergy-plus - Mouse and keyboard sharing utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517977





--- Comment #4 from Martin Gieseking <martin.gieseking at uos.de>  2009-08-18 14:20:38 EDT ---
Here comes the full review. :)

I'm not familiar with the Fedora policy concerning larger upstream changes that
require substantial changes of the spec file. If the next release becomes
officially available, you should clarify whether another review is needed. I
guess, it's not.


$ rpmlint /var/lib/mock/fedora-11-i386/result/*.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.


---------------------------------
keys used in following checklist:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
    acoording to the file comment headers license is GPLv2 only 

[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The license file included with the tarball must be part of the %doc
section
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
    md5 hash is 2c565afe5f920d363eef38dd97449b73

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture,...
    - builds on all supported architectures

[+] MUST: All build dependencies must be listed in BuildRequires
[.] MUST: The spec file MUST handle locales properly.
    - no locales

[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files...
    - no shared libraries

[.] MUST: If the package is designed to be relocatable,...
    - package not designed to be relocatable

[.] MUST: A package must own all directories that it creates.
    - does not create directories

[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
    - no large documentation

[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[.] MUST: Header files must be in a -devel package.
    - no header files

[.] MUST: Static libraries must be in a -static package.
    - no static libs

[.] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability).
    - no pkgconfig files

[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1),...
    - no shared libraries

[.] MUST: In the vast majority of cases, devel packages must require the base
package
    - no -devel subpackage

[.] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
    - no .la files

[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file.
    - no GUI

[+] MUST: Packages must not own files or directories already owned by other
packages.

[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: All filenames in rpm packages must be valid UTF-8.


[+] SHOULD: The reviewer should test that the package builds in mock.
    - builds in mock

[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
    - builds on all supported architecture in koji

[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
    - no scriptlets used

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.